feat: Make props editable, closes #669 #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akryum
force-pushed
the
feat-editable-props
branch
from
829af54 to
2ea5023
Compare
simsim0709
pushed a commit
to simsim0709/vue-devtools
that referenced
this pull request
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #669
@Akryum I tried to achieve this feature without introducing a bunch of new code and reused the existing editing feature. Prop manipulation is OFF by default and must be enabled in the settings.
Also, the props edit feature is only implemented for Vue 2. If you think it should be added for v1 let me know.
If you're willing to merge this feature, ping me and I'll add some tests